Skip to content

Add IScopedAlternateLookup for scoped caches#771

Open
Copilot wants to merge 24 commits intomainfrom
copilot/add-iscopedalternatelookup
Open

Add IScopedAlternateLookup for scoped caches#771
Copilot wants to merge 24 commits intomainfrom
copilot/add-iscopedalternatelookup

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

Summary

  • add a new net9-only IScopedAlternateLookup API and expose it from IScopedCache
  • implement scoped alternate lookup wrappers for ScopedCache and AtomicFactoryScopedCache
  • add scoped alternate lookup unit coverage and default interface method tests
  • add concurrent soak coverage for scoped alternate lookup ScopedGetOrAdd paths, including the retry loop in AtomicFactoryScopedCache

Validation

  • dotnet format BitFaster.Caching/BitFaster.Caching.csproj
  • dotnet build BitFaster.Caching/BitFaster.Caching.csproj -f net9.0
  • dotnet test BitFaster.Caching.UnitTests/BitFaster.Caching.UnitTests.csproj -f net9.0
  • parallel_validation

Copilot AI and others added 2 commits April 15, 2026 07:07
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/dccf8c03-48f8-4e76-bf28-f77f9a51d303

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/dccf8c03-48f8-4e76-bf28-f77f9a51d303

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Comment thread BitFaster.Caching/ScopedCache.cs
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 15, 2026

Coverage Status

coverage: 99.159%. first build — copilot/add-iscopedalternatelookup into main

Copilot AI requested a review from bitfaster April 15, 2026 17:46
Comment thread BitFaster.Caching/ScopedCache.cs
Copilot AI and others added 2 commits April 15, 2026 19:03
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/72ba7d13-f135-44e5-ab2e-e3421636eee4

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/72ba7d13-f135-44e5-ab2e-e3421636eee4

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot AI requested a review from bitfaster April 15, 2026 19:08
Comment thread BitFaster.Caching.UnitTests/ScopedCacheSoakTests.cs Outdated
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/53059f04-e895-4186-a464-9cd3159d01ec

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot AI requested a review from bitfaster April 16, 2026 06:44
Comment thread BitFaster.Caching.UnitTests/ScopedCacheSoakTests.cs Outdated
Copilot AI and others added 3 commits April 16, 2026 06:53
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/7b7e1bc4-582b-4e81-b6a3-d21883ba1a98

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/7b7e1bc4-582b-4e81-b6a3-d21883ba1a98

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/7b7e1bc4-582b-4e81-b6a3-d21883ba1a98

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot AI requested a review from bitfaster April 16, 2026 07:22
Comment thread BitFaster.Caching/Atomic/AtomicFactoryScopedCache.cs
Copilot AI and others added 2 commits April 19, 2026 00:40
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/9e152adc-b66d-4ffd-90d7-7a0e53da6c48

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/9e152adc-b66d-4ffd-90d7-7a0e53da6c48

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot AI requested a review from bitfaster April 19, 2026 00:45
@bitfaster
Copy link
Copy Markdown
Owner

@copilot merge with main and resolve conflicts

Copilot AI and others added 2 commits April 19, 2026 03:35
Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/9d82c197-0392-4339-9bb3-a8357a50afc9

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 19, 2026

@copilot merge with main and resolve conflicts

Merged origin/main, resolved the AtomicFactoryScopedCacheSoakTests conflict, and pushed the result. The merge commit is 4eb1c3e, with a small follow-up cleanup in fea6277.

@bitfaster
Copy link
Copy Markdown
Owner

@copilot merge with main and resolve conflicts

Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 19, 2026

@copilot merge with main and resolve conflicts

Merged the latest origin/main, resolved the AtomicFactoryScopedCacheSoakTests naming conflict, and pushed the result in 691871e.

@bitfaster bitfaster marked this pull request as ready for review April 19, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants